-
Couldn't load subscription status.
- Fork 3.4k
Don't reuse a table name in testCreateTableWithLongColumnName #26992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuidetestCreateTableWithLongColumnName now uses distinct randomized table names for valid and invalid column length checks, preventing reuse-induced flakiness. Class diagram for updated testCreateTableWithLongColumnName methodclassDiagram
class BaseConnectorTest {
-tableNameWithValidColumnLength : String
-tableNameWithInvalidColumnLength : String
-validColumnName : String
-invalidColumnName : String
+testCreateTableWithLongColumnName()
+assertUpdate(query: String)
+columnExists(tableName: String, columnName: String) : boolean
+getQueryRunner() : QueryRunner
+verifyColumnNameLengthFailurePermissible(exception)
+maxColumnNameLength() : Optional<Integer>
}
class QueryRunner {
+tableExists(session, tableName: String) : boolean
}
BaseConnectorTest --> QueryRunner
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes - here's some feedback:
- Wrap the valid table creation and drop in a try/finally block to ensure cleanup even if an assertion fails.
- Use distinct table name prefixes like 'test_long_column_valid' and 'test_long_column_invalid' for clearer debugging when tests flop.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Wrap the valid table creation and drop in a try/finally block to ensure cleanup even if an assertion fails.
- Use distinct table name prefixes like 'test_long_column_valid' and 'test_long_column_invalid' for clearer debugging when tests flop.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Description
This should fix flakiness in Cassandra connector.
https://github.com/trinodb/trino/actions/runs/18550092870/job/52875890713
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
Summary by Sourcery
Tests: